Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/rom error #3177

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Fix/rom error #3177

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a3c444
fix rom error
ARR552 Jan 31, 2024
ce2586b
linter
ARR552 Jan 31, 2024
9bd7ffe
fix
ARR552 Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions state/batchV2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ func (s *State) ProcessAndStoreClosedBatchV2(ctx context.Context, processingCtx
return common.Hash{}, noFlushID, noProverID, err
}
processed, err := s.processBatchV2(ctx, &processingCtx, caller, dbTx)
if err != nil {
if err != nil && processed.ErrorRom == executor.RomError_ROM_ERROR_NO_ERROR {
log.Errorf("%s error processBatchV2: %v", debugPrefix, err)
return common.Hash{}, noFlushID, noProverID, err
}
Expand All @@ -392,7 +392,7 @@ func (s *State) ProcessAndStoreClosedBatchV2(ctx context.Context, processingCtx
log.Errorf("%s error isRomOOCError: %v", debugPrefix, err)
}

if len(processedBatch.BlockResponses) > 0 && !processedBatch.IsRomOOCError {
if len(processedBatch.BlockResponses) > 0 && !processedBatch.IsRomOOCError && processedBatch.RomError_V2 == nil {
for _, blockResponse := range processedBatch.BlockResponses {
err = s.StoreL2Block(ctx, processingCtx.BatchNumber, blockResponse, nil, dbTx)
if err != nil {
Expand Down
Loading