-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork13: EIP 7212 + modexp #361
Draft
zkronos73
wants to merge
34
commits into
develop-banana
Choose a base branch
from
develop-durian
base: develop-banana
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zkronos73
commented
Oct 2, 2024
•
edited
Loading
edited
- add new arithmetic instructions and helpers: ARITH_SECP256R1_ECADD_DIFFERENT, ARITH_SECP256R1_ECADD_SAME
- add F_MLOAD instruccion (it's used by last MODEXP implementation)
- update diagnostic test with these new features
Doubling formulas for Secp256r1
* fix bug redundant selectors and constants verification
add specific tests for secp256r1
zkronos73
changed the title
add pil of arith with new arithmetics
Fork13: EIP 7212 + modexp
Oct 15, 2024
* create minimal diagnostic test with durian features * fix bug on secp256r1 dbl helper
fix the audit issues (comments and unused constants) issues: 1,2,3
…0-rc.3-fork.13 Feature/update rom v9.0.0 rc.3 fork.13
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.