fixes pre-p256verify

0xPolygonHermez · Oct 10, 2024 · a6cbfac · a6cbfac
1 parent 88be1e9
commit a6cbfac
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/main/precompiled/pre-p256verify.zkasm b/main/precompiled/pre-p256verify.zkasm
@@ -38,6 +38,7 @@ funcP256VERIFY:
    E + 32 => E                         :MSTORE(readXFromCalldataOffset), CALL(readFromCalldataOffset); in: [readXFromCalldataOffset: offset value, readXFromCalldataLength: length value], out: [readXFromCalldataResult: result value]
    $ => E                              :MLOAD(readXFromCalldataResult), CALL(p256verify) ;in: [A: hash, B: r, C: s, D: x, E: y], out: [A: result, B: result_code]
    B                                   :JMPNZ(endP256VERIFYFail)
+   A                                   :JMPZ(preEndP256VERIFY)
 
    ; write result p256verify into memory
    0 => E

diff --git a/main/touched.zkasm b/main/touched.zkasm
@@ -36,6 +36,8 @@ isColdAddress:
     ; if address is a precompiled considered as warm address
     10 => B
     $                           :LT, JMPC(finishColdPrecompiled)
+    0x100 => B
+    $                           :EQ, JMPC(finishColdPrecompiled)
 
 checkWarmed:
     ; save current state root & load touched root

diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
     "test:zkasm": "node tools/run-tests-zkasm.js ./test --helpers ../main/helper.js",
     "eslint": "npx eslint tools/**.js && npx eslint counters/counters-executor.js",
     "eslint:fix": "npx eslint tools/**.js --fix && npx eslint counters/counters-executor.js --fix",
-    "test:gen": "node tools/parallel-testing/gen-parallel-tests.js",
+    "test:gen": "node tools/parallel-testing/gen-parallel-tests.js --skipVCounters",
     "test:start": "npx mocha --jobs $NUM_CPUS --timeout 0 --max-old-space-size=8192 --parallel \"tools/parallel-testing/parallel-tests/*.test.js\"",
     "report:free-inputs": "node tools/audit-tools/free-inputs-checker.js",
     "report:registry-op": "node tools/audit-tools/registry-op-checker.js"
@@ -44,7 +44,7 @@
   },
   "devDependencies": {
     "@0xpolygonhermez/zkevm-commonjs": "github:0xPolygonHermez/zkevm-commonjs#v8.0.0-fork.12",
-    "@0xpolygonhermez/zkevm-proverjs": "github:0xPolygonHermez/zkevm-proverjs#develop-durian",
+    "@0xpolygonhermez/zkevm-proverjs": "github:0xPolygonHermez/zkevm-proverjs#fix/secp256r1-dbl",
     "@0xpolygonhermez/zkevm-testvectors": "github:0xPolygonHermez/zkevm-testvectors#feature/add-rip7212",
     "chai": "^4.3.6",
     "chalk": "^3.0.0",