Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary code in process-tx.zkasm? #136

Closed
3for opened this issue Sep 28, 2022 · 1 comment
Closed

Unnecessary code in process-tx.zkasm? #136

3for opened this issue Sep 28, 2022 · 1 comment

Comments

@3for
Copy link

3for commented Sep 28, 2022

In https://github.com/0xPolygonHermez/zkevm-rom/blob/main/main/process-tx.zkasm#L130:

        HASHPOS => D
        1 => D

set D register twice, actually the D value 1 is used, so do we can remove HASHPOS => D here?
@krlosMata
Copy link
Contributor

you are right !!
Thanks for noticing it.
We will remove the unnecessary line in the coming days

@ignasirv ignasirv mentioned this issue Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@3for @krlosMata