Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pre eip155 #150

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Feature/pre eip155 #150

merged 2 commits into from
Oct 27, 2022

Conversation

ignasirv
Copy link
Contributor

@ignasirv ignasirv commented Oct 19, 2022 •
edited
Loading

  • Dont check chainID at rlp-process for legacy transactions
  • Moved onFinishBatch event to trigger event before assert
  • Dont compare tx chain id with sequencer chain id for legacy txs
  • Removed unnecessary D assignation, from issue (Unnecessary code in process-tx.zkasm? #136)

@cla-bot cla-bot bot added the cla-signed label Oct 19, 2022
@ignasirv ignasirv changed the base branch from main to develop October 19, 2022 09:34
@ignasirv ignasirv force-pushed the feature/pre-EIP155 branch 4 times, most recently from 5a17d6c to 6fba077 Compare October 19, 2022 10:55
@ignasirv ignasirv requested review from krlosMata, laisolizq, jbaylina and invocamanman and removed request for krlosMata, laisolizq and jbaylina October 19, 2022 13:09
@ignasirv ignasirv mentioned this pull request Oct 20, 2022
Merged
krlosMata
krlosMata approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit 974cf15 into develop Oct 27, 2022
@ignasirv ignasirv deleted the feature/pre-EIP155 branch October 27, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignasirv @krlosMata