Feature/st log tests #102
Merged
Feature/st log tests #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ignasirv
commented
Jul 15, 2022
ignasirv
commented
- stLogTests
- Fix overflow at savemem (use LT + JMPC not JMPN)
- Fix bug at MSTORE
- Fix overflow at logX opcode (use LT + JMPC not JMPN)
- stEIP158Specific tests
- Bug at mstore8
- Selfdestruct should not deduct 25000 gas if the balance to transfer is 0, although the dest account is empty
- stBadOpcodesTests
- Small optimization (change EQ + JMPC to JMPN)
- At en deploy, if memSizeLinearPoseidon, should stop deploy smt store
ignasirv
force-pushed
the
feature/stLogTests
branch
from
b825ec4 to
3442be8
Compare
main/process-tx.zkasm
Outdated
| @@ -414,6 +413,8 @@ endDeploy: | |||
| ; save offset memory and length to compute contract hash | |||
| E :MSTORE(memOffsetLinearPoseidon) | |||
| C :MSTORE(memSizeLinearPoseidon) | |||
| ; If 0 len, nothing to compute | |||
| C - 1 :JMPN(handleGas) | |||
There was a problem hiding this comment.
good one! can be 2 lines before this check also ^^
ignasirv
force-pushed
the
feature/stLogTests
branch
from
3442be8 to
e3c9b71
Compare
krlosMata
pushed a commit
that referenced
this pull request
Jan 26, 2024
Alias check in resulting Fp2 inverses computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.