Feature/comments storage #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasirv
force-pushed
the
feature/comments-storage
branch
from
987889e
to
5bdbb1d
Compare
ignasirv
force-pushed
the
feature/comments-storage
branch
from
5bdbb1d
to
a842ef6
Compare
krlosMata
requested changes
Nov 9, 2022
ignasirv
force-pushed
the
feature/comments-storage
branch
from
d8decf3
to
f2c360c
Compare
ignasirv
force-pushed
the
feature/comments-storage
branch
from
f2c360c
to
80ecfa8
Compare
ignasirv
force-pushed
the
feature/comments-storage
branch
from
823c804
to
f059257
Compare
krlosMata
requested changes
Nov 11, 2022
main/opcodes/crypto.zkasm
Outdated
| * - 10 poseidon | ||
| * - dynamic steps: 200 + 100 * length | ||
| * @process-opcode | ||
| * - stack input: offset, size |
There was a problem hiding this comment.
We should follow the style on opADD opcode.
- stack input: [offset, size]
- stack output: [hash]
There was a problem hiding this comment.
This comment applies for all comments
main/opcodes/crypto.zkasm
Outdated
| SP - 1 => SP | ||
| $ => E :MLOAD(SP--) ; offset | ||
| $ => C :MLOAD(SP) ; length | ||
| $ => E :MLOAD(SP--); offset => E |
There was a problem hiding this comment.
Suggested change
| $ => E :MLOAD(SP--); offset => E | |
| $ => E :MLOAD(SP--); [ offset => E ] |
There was a problem hiding this comment.
This comment applies for all comments
| 32 => D | ||
| ; A new hash with position 0 is started | ||
| 0 => HASHPOS | ||
|
|
||
| opSHA3Loop: | ||
|
|
||
| ; checks zk-counters |
There was a problem hiding this comment.
dynamic counters, check at each loop
ignasirv
force-pushed
the
feature/comments-storage
branch
from
9494e5e
to
295a1d2
Compare
Comment stack-operations opcodes group Pr review Comment log opcodes group Comment flow control opcodes group Comment flow crypto opcodes group PR review
ignasirv
force-pushed
the
feature/comments-storage
branch
from
295a1d2
to
9aa9958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.