Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement touched tree #167

Merged
merged 2 commits into from
Nov 11, 2022
Merged

implement touched tree #167

merged 2 commits into from
Nov 11, 2022

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • adds touched.zkasm to handle the tree regarding touched addresses & slots
  • removes old implementation
  • remove trailing spaces

@cla-bot cla-bot bot added the cla-signed label Nov 10, 2022
@krlosMata krlosMata marked this pull request as draft November 10, 2022 22:07
@krlosMata krlosMata marked this pull request as ready for review November 11, 2022 08:44
ignasirv
ignasirv reviewed Nov 11, 2022
View reviewed changes
main/touched.zkasm Outdated Show resolved Hide resolved
ignasirv
ignasirv reviewed Nov 11, 2022
View reviewed changes
main/touched.zkasm Outdated Show resolved Hide resolved
invocamanman
invocamanman reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@invocamanman invocamanman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be way more intuitive if isWarm return 0 if colf and 1 if warm or change the name to isCold

main/touched.zkasm Show resolved Hide resolved
ignasirv
ignasirv approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata merged commit 850b1b2 into develop Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasirv ignasirv ignasirv approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlosMata @ignasirv @invocamanman