Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor changes + last commit zkasmcom #170

Merged
merged 2 commits into from
Nov 15, 2022
Merged

minor changes + last commit zkasmcom #170

merged 2 commits into from
Nov 15, 2022

Conversation

krlosMata
Copy link
Contributor

@krlosMata krlosMata commented Nov 14, 2022 •
edited
Loading

This PR does the following:

  • update zksmcom to last commit
    • isCode memory section is deleted
    • memory is now 4MB
  • remove modexp
  • $ --> $$
    • fixed in zkproverjs
  • remove label handleInvalidStatic
  • fix get SR before any invalidIntrinsic found by @invocamanman

@cla-bot cla-bot bot added the cla-signed label Nov 14, 2022
@krlosMata krlosMata force-pushed the feature/update-asmcom branch 2 times, most recently from 2a48a09 to 8ae78ac Compare November 15, 2022 11:14
laisolizq
laisolizq approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@laisolizq laisolizq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit d07efb9 into develop Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laisolizq laisolizq laisolizq approved these changes

@ignasirv ignasirv ignasirv approved these changes

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlosMata @ignasirv @laisolizq