Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/batch header #173

Merged
merged 4 commits into from
Nov 17, 2022
Merged

Feature/batch header #173

merged 4 commits into from
Nov 17, 2022

Conversation

krlosMata
Copy link
Contributor

@krlosMata krlosMata commented Nov 17, 2022 •
edited
Loading

This PR does the following:

  • not update GER on L2 if it is equal to 0
  • additional info on L2 for each GER is changed from numBatch to timestamp
  • rename BATCH_GAS_LIMIT to TX_GAS_LIMIT
  • update keccaks computations to last changes

@cla-bot cla-bot bot added the cla-signed label Nov 17, 2022
@krlosMata krlosMata marked this pull request as draft November 17, 2022 10:57
@krlosMata krlosMata removed the request for review from jbaylina November 17, 2022 10:57
@krlosMata krlosMata marked this pull request as ready for review November 17, 2022 12:52
ignasirv
ignasirv approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata merged commit c0ad4ec into develop Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invocamanman invocamanman invocamanman approved these changes

@ignasirv ignasirv ignasirv approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlosMata @ignasirv @invocamanman