Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments comparison opcodes #176

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Comments comparison opcodes #176

merged 3 commits into from
Nov 28, 2022

Conversation

laisolizq
Copy link
Contributor

@laisolizq laisolizq commented Nov 21, 2022 •
edited by krlosMata
Loading

This PR does the following:

  • fix typo in file name comparision.zkasm
  • add comments to all opcodes in comparison.zkasm
  • fix mulMOD when taking 256 less significant bits of the result mulmod
  • re-implement sar opcode to not have unsecure operations and optimize it
  • precalculate steps counters in checkHashBytecodeLoop loop

@cla-bot cla-bot bot added the cla-signed label Nov 21, 2022
@krlosMata krlosMata force-pushed the feature/comment-comp branch 3 times, most recently from 3e33af1 to 74426d1 Compare November 28, 2022 14:31
@krlosMata krlosMata changed the title Comments comparision opcodes Comments comparison opcodes Nov 28, 2022
ignasirv
ignasirv approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

krlosMata
krlosMata approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laisolizq --> 😸

@krlosMata krlosMata merged commit 2248432 into develop Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

@ignasirv ignasirv ignasirv approved these changes

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laisolizq @ignasirv @krlosMata