Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/counter steps #180

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Fix/counter steps #180

merged 5 commits into from
Nov 30, 2022

Conversation

ignasirv
Copy link
Contributor

@ignasirv ignasirv commented Nov 23, 2022

Increase min steps in some checks (specially loops). We need min 200 steps to finish the tx correctly

  • Deducted 200 steps from steps const, used to finish the tx

@cla-bot cla-bot bot added the cla-signed label Nov 23, 2022
@ignasirv ignasirv marked this pull request as ready for review November 23, 2022 14:18
@ignasirv ignasirv force-pushed the fix/counter-steps branch 3 times, most recently from d60d5af to eaa0cac Compare November 28, 2022 16:24
@ignasirv ignasirv marked this pull request as draft November 28, 2022 16:24
@ignasirv ignasirv marked this pull request as ready for review November 29, 2022 08:40
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

main/constants.zkasm Outdated Show resolved Hide resolved
@krlosMata krlosMata merged commit c0429f9 into develop Nov 30, 2022
@ignasirv ignasirv deleted the fix/counter-steps branch November 30, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants