Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boundaries check fixes #228

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Boundaries check fixes #228

merged 4 commits into from
Jan 17, 2023

Conversation

ignasirv
Copy link
Contributor

@ignasirv ignasirv commented Jan 16, 2023 •
edited by krlosMata
Loading

Audit fixes:

@cla-bot cla-bot bot added the cla-signed label Jan 16, 2023
@ignasirv ignasirv marked this pull request as ready for review January 16, 2023 15:41
@ignasirv ignasirv force-pushed the hotfix/audit-w2 branch 3 times, most recently from 147ba77 to f24d137 Compare January 16, 2023 16:13
@krlosMata krlosMata self-requested a review January 17, 2023 12:18
krlosMata
krlosMata approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit 83677d1 into develop Jan 17, 2023
@ignasirv ignasirv deleted the hotfix/audit-w2 branch January 17, 2023 15:27
chriseth
chriseth reviewed Mar 14, 2023
View reviewed changes
main/opcodes/calldata-returndata-code.zkasm
; if offset is lower than calldata length, return 0
$ :LT,JMPC(CALLDATALOADreturn0)
B => E
$ => A :MLOAD(SP); [offset => B]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offset => B -> offset => A

chriseth
chriseth reviewed Mar 14, 2023
View reviewed changes
main/opcodes/calldata-returndata-code.zkasm
@@ -94,7 +94,7 @@ opCALLDATACOPY:
; check stack underflow
SP - 3 => SP :JMPN(stackUnderflow)
$ => E :MLOAD(SP+2); [destOffset => E]
$ => B :MLOAD(SP+1); [offset => B]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offset => B -> offset => A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth left review comments

@krlosMata krlosMata krlosMata approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ignasirv @chriseth @krlosMata