Set on update storage at the beginning of sstore #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasirv
requested review from
krlosMata,
laisolizq and
invocamanman
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small fix is necessary to allow the full tracer to get the onUpdateStorage values for an
SSTOREopcode that fails.Motivation:
SSTOREopcode that fails (for example an oog), the Geth trace is returning the (not inserted) key and values of the sstore. This is currently imposible for the full tracer because in case of oog atSSTOREthe call toonUpdateStorageis not reached so the key and value are no available for the trace.