Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #311

Merged
merged 28 commits into from
Nov 21, 2023
Merged

Develop #311

merged 28 commits into from
Nov 21, 2023

Conversation

krlosMata
Copy link
Contributor

move develop to main

MCJOHN974 and others added 28 commits September 25, 2023 19:14
@MCJOHN974
Running all tests even if one was failed
52d9e77
@MCJOHN974
Exit code handling
25f6869
@MCJOHN974
switch to bool flag instead exit code
2071913
@zkronos73
changes ecrecover to use extra arithmetic features and fix some bugs
5802be4
@zkronos73
add some comments and improvements
6f4fb20
@zkronos73
update comments and fix
6ef49e2
@krlosMata
Merge pull request #306 from MCJOHN974/main
a4e9c3a 
Do not skip tests in ``run-tests-zkasm.js``
@zkronos73
updating counters information
69f40c5
@zkronos73
fix typo on checkSqrtFpEc
685ecd8
@zkronos73
update counters stimation ecrecover
d23ded4
@krlosMata
gha add ssh key
8bdf9c9
@zkronos73
Merge pull request #35 from 0xPolygonHermez/feature/gha-internal
1c4193f 
gha add ssh key
@zkronos73
add more specific tests
8fd2908
@zkronos73
fix a bug and add more tests
bf318fb
@zkronos73
fix bug tests on package.json
a6fa3f1
@zkronos73
fix typos and adjusts binary counters
73df4d5
@krlosMata
Merge pull request #36 from 0xPolygonHermez/fix/ecrecover-alias-diffe…
8ceca9a 
…quals-sqrt

fix/ecrecover alias diffequals sqrt
@zkronos73
update fork id constant
2e4dbe4
@zkronos73
update package.json with testvector updated
2d02d2b
@krlosMata
Merge pull request #39 from 0xPolygonHermez/fix/update-fork-id
70fece7 
update fork id constant
@zkronos73
add management of point at infinity
e132ff2
@zkronos73
error on point-at-infinity + comments + fix dual path
8b43d3e
@zkronos73
add comments and extra test
ccb6141
@zkronos73
add more tests
e78c976
@krlosMata
Merge pull request #42 from 0xPolygonHermez/fix/ecrecover-point-at-in…
994aa21 
…finity

fix/ecrecover point at infinity
@krlosMata
update packages to fork.6
f3b6d78
@krlosMata
Merge pull request #310 from 0xPolygonHermez/feature/incaberry
de55837 
Feature/incaberry
@krlosMata
update test-vectors package
7e76c74
@cla-bot cla-bot bot added the cla-signed label Nov 21, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ignasirv
ignasirv approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata merged commit 877328e into main Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laisolizq laisolizq laisolizq approved these changes

@ignasirv ignasirv ignasirv approved these changes

@zkronos73 zkronos73 Awaiting requested review from zkronos73 zkronos73 is a code owner

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krlosMata @ignasirv @laisolizq @MCJOHN974 @zkronos73