-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop etrog #319
Merged
Merged
Develop etrog #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finity fix/ecrecover point at infinity
Set l2 tx hash computing at rlp parsing Fix counters + counter tests Fix log index add pairings add modexp fixes & updates forkid6 update tests zkasm & helpers Cleaning the repo Fixing tests Minor refactor and removing unnecessary zkasm files Cleaning the repo Removing some comments and moving unused files Big refactor of pairings Test passing now with a minor refactor Test refactor and module tree fixed Finished cleaning the pairing repo. Unused helpers removed Finished cleaning the modexp repo Setting the new number of chunks limit based on the gas limit Reorganization and optimizations fix modexp add tool labels last fixes & comments fix mulArith fix imports update package update package update GHA fix modexp gas fix outofgas modexp & delete helpers update package Optimizations and code clarifications Splitting the main operations in modexp and starting to perform tests... Bug in long divison fixed Fixing soundness errors in Fp arithemtic Modexp-op1 test generator update GHA fork-etrog fix selector add first counters modexp Uncovered paths fixed Some minor optimizations Almost all counters added. Some major optimizations. Ended the expected optimizations update pre-modexp counters Modexp counters done Fixing minor typos and uncommenting the counters
Fix counters modexp & add sha256
Feature/sha256 l1 info tree
Feature/l1 info tree
Setting the accurate modexp input length
Fix various completeness issues in array lib
add fixes to wrong comments
Fix soundness issues in array div long/short
Fix incorrect counters calculations in array div long/short
Cumulative gas used fix
update commonjs & testvectors cumulative-gas-fix
Feature/new l2hash
Feature/fork etrog
krlosMata
requested review from
laisolizq,
ignasirv,
zkronos73 and
invocamanman
as code owners
January 26, 2024 09:46
ignasirv
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
develop-etrog
todevelop