Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add recommendation review external #337

Draft
wants to merge 1 commit into
base: develop-eldelberry
Choose a base branch
from
Draft

add recommendation review external #337

wants to merge 1 commit into from

Conversation

krlosMata
Copy link
Contributor

  • fix empty list when decoding RLP
  • remove unnecessary variables, functions, constants, redundant jumps & unused labels
  • use constant %MAX_UINT_256
  • update link
  • add optimization on checkBytecodeStartsEF
  • apply some optimization to shorten code

@cla-bot cla-bot bot added the cla-signed label Feb 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ignasirv
ignasirv approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata marked this pull request as draft February 11, 2024 09:56
@krlosMata krlosMata mentioned this pull request Feb 13, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasirv ignasirv ignasirv approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlosMata @ignasirv