-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modexp revision #341
Merged
Merged
Modexp revision #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecmas
requested review from
laisolizq,
krlosMata,
ignasirv,
zkronos73 and
invocamanman
as code owners
February 12, 2024 15:47
hecmas
changed the base branch from
feature/modexp-tests
to
develop-eldelberry
February 12, 2024 15:48
Closed
hecmas
force-pushed
the
feature/array-len
branch
4 times, most recently
from
February 18, 2024 15:46
a748df9
to
232193b
Compare
hecmas
force-pushed
the
feature/array-len
branch
from
March 14, 2024 07:51
74cebd4
to
6015004
Compare
hecmas
force-pushed
the
feature/array-len
branch
3 times, most recently
from
March 25, 2024 09:41
de4563f
to
74cb873
Compare
hecmas
force-pushed
the
feature/array-len
branch
from
March 25, 2024 16:26
8d9ed3b
to
28f4e0a
Compare
hecmas
force-pushed
the
feature/array-len
branch
from
March 25, 2024 18:01
28f4e0a
to
5e43ad9
Compare
last fixes pre-modexp
Quality Gate passedIssues Measures |
ignasirv
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several corrections and optimizations to the
modexp
folder:array _utils
folder has been removed. Functions inside it (i.e.,array_compare
) are now performed directly in the array arithmetic operations. This avoids the unnecessary actions of copying memory from one place to another if its not needed.array_mul_long
avoids the need of cleaning the previous output of a previous long multiplication.array_div_short
andarray_div_long
assume that the denominator cannot be zero (which is a save assumption in the context of modexp).