Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix prove zeroes #363

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Feature/fix prove zeroes #363

merged 3 commits into from
Mar 25, 2024

Conversation

krlosMata
Copy link
Contributor

  • add ability to prove future l1 info tree indexes

@cla-bot cla-bot bot added the cla-signed label Mar 24, 2024
@krlosMata krlosMata force-pushed the feature/fix-prove-zeroes branch from 4aa0eea to 8cea7ab Compare March 24, 2024 15:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ignasirv
ignasirv approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@krlosMata krlosMata merged commit 72a8707 into develop Mar 25, 2024
4 checks passed
@lyh169
Copy link

lyh169 commented Jul 22, 2024

Hello ,why add prove zeroes, Did you find some issue about this?

@krlosMata
Copy link
Contributor Author

yes, empty indexes on the l1InfoTree have 0 value.
The ROM forces you to build the value of the l1InfoTreebuild such as: keccak(globalExitRoot, bloickHash, timestamp). Therefore, it was not possible to build a value of 0.
We add this ability in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasirv ignasirv ignasirv approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlosMata @lyh169 @ignasirv