Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARITH implementation #60

Merged
merged 1 commit into from
May 17, 2022
Merged

ARITH implementation #60

merged 1 commit into from
May 17, 2022

Conversation

ignasirv
Copy link
Contributor

  • Notations from the code review
  • Renaming of variable and minor fixes found while review
  • ARITH implementation for all usage from implemented utils function

Commit messages before squash:

more notations
more notatioons
fix notations + remove unnecessary D assignation at main
Rename: batchL2DataRead -> batchL2DataParsed
Explain variable
Rename: txsListLength -> batchL2DataLength
Rename: txListLength -> txRLPLength
Rename: txIsCreateContract -> isCreateContract
Rename: create2 -> isCreate2
Rename: txNData -> txCalldataLen
Rename: gasSpendCallError -> computeGasSendCall + spellcheck oopCODESIZE
Rename: staticCall -> isStaticCall
check batch_number !exist --> return 0
Arith checks

@ignasirv
Fix opInvalid for main context (the opcode is not finished yet)
b5ee191 
WIP

more notations

WIP notations

WIP 3

more notatioons

fix notations + remove unnecessary D assignation at main


Rename: batchL2DataRead -> batchL2DataParsed


Explain variable


Rename: txsListLength -> batchL2DataLength


Rename: txListLength -> txRLPLength


Rename: txIsCreateContract -> isCreateContract


Rename: create2 -> isCreate2


Rename: txNData -> txCalldataLen 


Rename: gasSpendCallError -> computeGasSendCall + spellcheck oopCODESIZE


Rename: staticCall -> isStaticCall


check batch_number !exist --> return 0


Arith checks
@ignasirv ignasirv changed the title Fix opInvalid for main context (the opcode is not finished yet) ARITH implementation May 17, 2022
krlosMata
krlosMata approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit 4789b42 into develop May 17, 2022
@ignasirv ignasirv deleted the opcodes branch July 13, 2022 14:43
krlosMata added a commit that referenced this pull request Jan 26, 2024
@krlosMata
Merge pull request #60 from 0xPolygonHermez/feature/ep-l2txhash
93984c7 
Feature/ep l2txhash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignasirv @krlosMata