Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SHR/SHL arith #63

Closed
wants to merge 4 commits into from
Closed

update SHR/SHL arith #63

wants to merge 4 commits into from

Conversation

laisolizq
Copy link
Contributor

  • Add utils SHR/SHL with :ARITH
  • Update all SHR/SHL
  • some SHR/SHL have not been updated because they will be replaced in the next PR

ignasirv and others added 3 commits May 17, 2022 12:55
@ignasirv @krlosMata
Fix opInvalid for main context (the opcode is not finished yet)
e0636a8 
WIP

more notations

WIP notations

WIP 3

more notatioons

fix notations + remove unnecessary D assignation at main


Rename: batchL2DataRead -> batchL2DataParsed


Explain variable


Rename: txsListLength -> batchL2DataLength


Rename: txListLength -> txRLPLength


Rename: txIsCreateContract -> isCreateContract


Rename: create2 -> isCreate2


Rename: txNData -> txCalldataLen 


Rename: gasSpendCallError -> computeGasSendCall + spellcheck oopCODESIZE


Rename: staticCall -> isStaticCall


check batch_number !exist --> return 0


Arith checks
@krlosMata
rebase main
a0cfd1d
@laisolizq
update SHR/SHL arith
5fb4d14
@laisolizq laisolizq requested review from ignasirv and krlosMata May 18, 2022 09:22
@laisolizq laisolizq force-pushed the feature/shr-shl-arith branch from 0ec2dda to 982bf5d Compare May 19, 2022 10:38
@laisolizq laisolizq closed this May 19, 2022
krlosMata pushed a commit that referenced this pull request Jan 26, 2024
@hecmas
Merge pull request #63 from 0xPolygonHermez/feature/optimize-arrays
623f2cb 
optimize arrays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasirv ignasirv Awaiting requested review from ignasirv ignasirv is a code owner

@krlosMata krlosMata Awaiting requested review from krlosMata krlosMata is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laisolizq @ignasirv @krlosMata