Feature/oog #74
Merged
Feature/oog #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laisolizq
commented
May 26, 2022
laisolizq
commented
- check out of gas
- check stack over flow (it will be necessary to update this)
ignasirv
requested changes
May 31, 2022
krlosMata
requested changes
May 31, 2022
| @@ -12,13 +12,15 @@ opSTOP: | |||
| GAS + B => GAS | |||
| $ => SP :MLOAD(lastSP) | |||
| $ => PC :MLOAD(lastPC) | |||
| 1 :MSTORE(SP++) ; // TODO: call to an EOA address, what is going on ? | |||
| 1 :MSTORE(SP++) | |||
There was a problem hiding this comment.
Remove comments at the beginning of the file
main/opcodes.zkasm
Outdated
| :JMP(readCode) | ||
|
|
||
| opSTOPend: | ||
| :JMP(endCode) | ||
|
|
||
| opADD: | ||
| SP - 2 :JMPN(stackOverflow) |
There was a problem hiding this comment.
This error should be renamed to: stackUnderflow
And just add the label stackUnderflow just above stackOverflow since the routine would be exactly the same.
This apply for the rest of this errors
| :JMP(sendGasSeq) | ||
|
|
||
| stackOverflow: |
There was a problem hiding this comment.
Ethereum yellow paper quotation:
if the execution halts in an exceptional
fashion (i.e. due to an exhausted gas supply, stack underflow, invalid jump destination or invalid instruction), then
no gas is refunded to the caller and the state is reverted to
the point immediately prior to balance transfer (i.e.
main/utils.zkasm
Outdated
| :JMP(stackOverflow) | ||
|
|
||
| stackOverflowEnd: |
There was a problem hiding this comment.
Stack overflowcould be check by doing a recursive function: https://stackoverflow.com/questions/70315824/solidity-stack-limit-reached-10241023-when-trying-to-burnStack underflowcould be checked by trying topopa variable when it does not exist (source: https://medium.com/hackernoon/how-to-debug-ethereum-smart-contracts-7efd883d8cc3)
invocamanman
approved these changes
Jun 2, 2022
krlosMata
added a commit
that referenced
this pull request
Jan 26, 2024
Add on step for unsigned transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.