Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ecrecover #76

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Update ecrecover #76

merged 1 commit into from
Jun 8, 2022

Conversation

laisolizq
Copy link
Contributor

  • Update :ECRECOVER to CALL(ecrecover)
  • Update precompiled ecrecover

@laisolizq laisolizq requested a review from krlosMata June 3, 2022 09:58
krlosMata
krlosMata requested changes Jun 5, 2022
View reviewed changes
package.json Outdated
@@ -23,6 +23,7 @@
},
"dependencies": {
"ffjavascript": "^0.2.46",
"zkasm": "https://github.com/hermeznetwork/zkasm.git"
"zkasm": "https://github.com/hermeznetwork/zkasm.git",
"zk_ecrecover": "https://github.com/hermeznetwork/zk_ecrecover.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be changed to this approach from now on:
https://github.com/hermeznetwork/zkrom/blob/main/package.json#L25

@laisolizq laisolizq force-pushed the feature/update-ecrecover branch from 4781023 to ecff8bb Compare June 7, 2022 14:40
@laisolizq laisolizq force-pushed the feature/update-ecrecover branch from ecff8bb to 16fcac6 Compare June 7, 2022 14:44
@laisolizq laisolizq requested a review from krlosMata June 7, 2022 14:44
krlosMata
krlosMata approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit e8b1d3d into main Jun 8, 2022
krlosMata added a commit that referenced this pull request Jan 26, 2024
@krlosMata
Merge pull request #76 from 0xPolygonHermez/feature/fix-freeinput
9d05172 
Fix multiple free inputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laisolizq @krlosMata