Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/delete getbyte 2 #80

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Feature/delete getbyte 2 #80

merged 2 commits into from
Jun 17, 2022

Conversation

laisolizq
Copy link
Contributor

Delete getByte function:

  • deploy --> calldata (globalHash data)
  • create --> memory

@laisolizq laisolizq requested a review from krlosMata June 17, 2022 14:53
krlosMata
krlosMata requested changes Jun 17, 2022
View reviewed changes
main/utils.zkasm Outdated
D => B
1 => D
;${log(A)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment could be removed

main/opcodes.zkasm Outdated
@@ -2066,7 +2077,7 @@ opCREATE:
B :MSTORE(txSrcAddr)
B :MSTORE(txSrcOriginAddr)
; TODO is not encesesaary to load and store GAS, bc is global var
:CALL(copySP)
; :CALL(copySP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be removed?

main/opcodes.zkasm Outdated
@@ -2544,7 +2555,7 @@ opCREATE2:
B :MSTORE(txSrcAddr)
B :MSTORE(txSrcOriginAddr)
; TODO is not encesesaary to load and store GAS, bc is global var
:CALL(copySP)
; :CALL(copySP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be removed?

@laisolizq laisolizq requested a review from krlosMata June 17, 2022 15:13
krlosMata
krlosMata approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit 518bbcd into feature/newleaf-and-hashbytecode Jun 17, 2022
krlosMata added a commit that referenced this pull request Jan 26, 2024
@krlosMata
Merge pull request #80 from 0xPolygonHermez/feature/fix-audit-pre
e8a69bf 
fix modexp copy memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laisolizq @krlosMata