Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add counters limitations #91

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Add counters limitations #91

merged 5 commits into from
Jul 13, 2022

Conversation

ignasirv
Copy link
Contributor

@ignasirv ignasirv commented Jul 7, 2022

  • Add counters at each opcode
  • Add max counters at const file

krlosMata
krlosMata requested changes Jul 8, 2022
View reviewed changes
main/utils.zkasm Outdated Show resolved Hide resolved
main/constants.zkasm Outdated Show resolved Hide resolved
@ignasirv ignasirv force-pushed the feature/zk-counters branch 3 times, most recently from 7e612ba to 29c6737 Compare July 11, 2022 09:27
laisolizq
laisolizq approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@laisolizq laisolizq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

krlosMata
krlosMata requested changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a folder in the repository called docs.
We could place there the opcode-cost-zk-counters.md with the table of each opcode zk-counters code

main/vars.zkasm Outdated Show resolved Hide resolved
@ignasirv ignasirv force-pushed the feature/zk-counters branch from 88e7ba0 to 9a75246 Compare July 12, 2022 12:58
@krlosMata krlosMata self-requested a review July 12, 2022 14:27
krlosMata
krlosMata approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata mentioned this pull request Jul 13, 2022
Closed
@ignasirv ignasirv force-pushed the feature/zk-counters branch from 99ddaf6 to 805e0b8 Compare July 13, 2022 14:59
@krlosMata krlosMata merged commit 1368e3e into main Jul 13, 2022
krlosMata added a commit that referenced this pull request Jan 26, 2024
@krlosMata
Merge pull request #91 from 0xPolygonHermez/feature/fix-array-mul-short
037afed 
fix array_mul_short_carry_check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

@laisolizq laisolizq laisolizq approved these changes

@invocamanman invocamanman invocamanman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ignasirv @invocamanman @laisolizq @krlosMata