-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #610
Merged
Merged
Develop #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Credentials are returned with paginated wrapper on API UI * chore: request params and response tested * chore: Encapsulate getCredentialsResponse * chore: Credentials pagination propagated to the whole flow and properly tested. * fix: Wrong parameter rename * chore: Avoid counting total rows if we don't need pagination * chore: Avoid counting total rows if we don't need pagination * chore: return always maxResults field with the value sent by the user. If an invalid number is set, default value(50) is returned --------- Co-authored-by: Martin Saporiti <martinsaporiti@gmail.com>
…-issuer-node-docker-containers chore: add health check to docker containers
* WIP: Return raw or link qrcode for backward compatibillity * chore: Merge develop and QRs by type tested * chore: Tested CreateLinkWithQrcode endpoint * chore: Compact GetCredentialQrCode response in a struct * chore: Remove TODO comment. This should go to Jira.
* user RFC3339Nano instead of RFC3339 * fix unit test
…nID/issuer-node into feature/support-refresh-service
feat: support refresh service
* feat: Parse sort by param in get credentials and refuse wrong entries * feat: GetCredentials repo construct sql query based on filters.SortBy * chore: Move order by filters to its own package * feat: Fix typo in query and add 2 more testcases
* feat: adding pagination con connections endpoint * fix: merge conflict --------- Co-authored-by: x1m3 <ximebcn@yahoo.es>
…ages chore: improve errors messages
fix: get state status endpoint
chore: Update vite version
… the text as a link
…-on-frontend' into PID-1651-support-refresh-service-on-frontend # Conflicts: # ui/src/adapters/api/credentials.ts
…vice-on-frontend feat: UI can create credentials with refresh service field
…of-credentials chore: avoid fetching credentials with empty mtp proofs
Support display method
…dpoint-to-pending-publisher-and-notifications-components chore: add health check endpoint
# Conflicts: # go.sum
chore: Merge conflict
x1m3
approved these changes
Jan 30, 2024
martinsaporiti
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.