Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pid 2645 implement aws secret storage provider #848

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

martinsaporiti
Copy link
Contributor

No description provided.

@martinsaporiti martinsaporiti requested a review from a team as a code owner November 19, 2024 13:04
Copy link

gitguardian bot commented Nov 19, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14295020 Triggered Generic High Entropy Secret 129144c internal/kms/aws_secret_storage_provider_test.go View secret
8664826 Triggered Generic Password 004c9a9 k8s/helm/values.yaml View secret
14295020 Triggered Generic High Entropy Secret 129144c internal/kms/aws_secret_storage_provider_test.go View secret
14295020 Triggered Generic High Entropy Secret 129144c internal/kms/aws_secret_storage_provider_test.go View secret
14295020 Triggered Generic High Entropy Secret bc715b3 internal/kms/aws_secret_storage_provider_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@martinsaporiti martinsaporiti self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant