Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: credential raw value field #371

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Conversation

plusema86
Copy link
Contributor

added a new field on the credential object saved in the database, this is needed to be able to access the original value of the credential

emuroni added 4 commits January 17, 2024 11:56
@plusema86 plusema86 requested a review from jrl351 January 26, 2024 14:58
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (24d10bb) 26.12% compared to head (611b8ea) 26.45%.

Files Patch % Lines
...ata/data_sources/remote_iden3comm_data_source.dart 14.28% 6 Missing ⚠️
lib/credential/data/dtos/claim_dto.dart 97.29% 1 Missing ⚠️
lib/credential/domain/entities/claim_entity.dart 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #371      +/-   ##
===========================================
+ Coverage    26.12%   26.45%   +0.33%     
===========================================
  Files          300      300              
  Lines         7387     7415      +28     
===========================================
+ Hits          1930     1962      +32     
+ Misses        5457     5453       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jrl351 jrl351 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward.

@jrl351 jrl351 merged commit 1c6ca02 into develop Jan 29, 2024
4 checks passed
@jrl351 jrl351 deleted the feature/credential-raw-value-field branch January 29, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants