Add support for list comprehensions to parser #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
7 times, most recently
from
91e2212 to
ec96dbe
Compare
tohrnii
force-pushed
the
tohrnii-refactor-exp
branch
from
352437d to
ddafabd
Compare
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
2 times, most recently
from
a2cc0be to
6f18076
Compare
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
4 times, most recently
from
15a4c3c to
7593ee9
Compare
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
from
0d941e5 to
ed1abb3
Compare
tohrnii
force-pushed
the
tohrnii-refactor-exp
branch
from
a2e5990 to
1d00295
Compare
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
2 times, most recently
from
44ec2ee to
2445536
Compare
tohrnii
force-pushed
the
tohrnii-refactor-exp
branch
from
1d00295 to
9bfac4c
Compare
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
2 times, most recently
from
98f7e0a to
49bf627
Compare
tohrnii
force-pushed
the
tohrnii-refactor-exp
branch
from
9bfac4c to
0a46017
Compare
|
Based on an example by @bobbinth (in rescue prime constraints), we would need to be able to do something like: However, the PR in the current form doesn't support these kinds of expressions. I'll update this PR to allow such expressions. Edit: This would be handled in another PR. |
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
from
dc8fa06 to
8db9bf4
Compare
bobbinth
reviewed
Jan 30, 2023
There was a problem hiding this comment.
Looks good to me! Thank you! I did leave one comment inline: basically, not sure if the current implementation is a simplification of where we want to be. Fine if so, but if not - I think we need to have a more general structure which could handle many iterable lists.
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
6 times, most recently
from
5fd2d8d to
d358bec
Compare
bobbinth
approved these changes
Jan 31, 2023
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
from
d358bec to
5d30017
Compare
tohrnii
force-pushed
the
tohrnii-list-comprehension
branch
from
5d30017 to
580e060
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addressing #87. This PR adds list comprehension support to the parser. This PR should be merged after #120.