fix: fix codegen for aux transition constraints that use main cols #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohrnii
force-pushed
the
tohrnii-codegen-fix
branch
from
5075e7e to
e716bc4
Compare
tohrnii
force-pushed
the
tohrnii-codegen-fix
branch
2 times, most recently
from
8755a5d to
56800de
Compare
bobbinth
reviewed
Feb 17, 2023
tohrnii
force-pushed
the
tohrnii-codegen-fix
branch
from
56800de to
a51bd6d
Compare
bobbinth
reviewed
Feb 17, 2023
tohrnii
force-pushed
the
tohrnii-codegen-fix
branch
from
a51bd6d to
9c83bad
Compare
bobbinth
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the codegen to correctly generate code for constraints that use both aux trace columns and main trace columns.