-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitwise constraints submodule refactor for modularity #213
Conversation
dea6fa6
to
4659dc7
Compare
Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @grjte, I left a few points of discussions/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! This is not a full review - but I did leave a couple of comments inline.
# Enforces that column must be binary | ||
### Helper functions/evaluators ################################################################### | ||
|
||
#! Enforces that column must be binary. | ||
ev check_binary(main: [a]): | ||
enf a^2 - a = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for the future: I wonder if we should add some "built-in" functions to help with things like this. For example, we could have is_binary()
defined on the language level so that we don't have to redefine it in different modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobbinth I was thinking we could have something like a standard lib for simple functions and evaluators like these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's discuss this for the future. It would be a nice thing to add perhaps in v0.4
4659dc7
to
4e67557
Compare
Thank you all for the preliminary review & discussion. I believe we're aligned on syntax for submodules now as summarized in #122 , and I've updated the PR accordingly, so it's now ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @grjte, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @grjte!
This PR is a proposed restructuring of the bitwise constraints updated in #180 to address the discussion in #122. This PR is based on #180, since it hasn't been merged yet.
The purpose of this is to make sure we're aligned on syntax and submodules before we write the rest of the constraints. (although note that this is a very minor change, so updating other files would still be simple)
A couple open questions:
v0.3
mod
instead ofdef
here as a proposal