Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IntegrityStmt #216

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Refactor IntegrityStmt #216

merged 5 commits into from
Mar 17, 2023

Conversation

tohrnii
Copy link
Contributor

@tohrnii tohrnii commented Mar 13, 2023

This PR refactors the IntegrityStmt to make it easy to incorporate selectors.

@tohrnii tohrnii requested review from grjte and Fumuran and removed request for grjte March 13, 2023 12:28
@tohrnii tohrnii force-pushed the tohrnii-parser-refactor branch from 2a0f08e to e88e084 Compare March 13, 2023 12:30
grjte
grjte suggested changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@grjte grjte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tohrnii, looks good to me overall, just a few very minor nits

ir/src/constraint_builder/integrity_constraints/mod.rs Outdated Show resolved Hide resolved
parser/src/parser/tests/random_values.rs Outdated Show resolved Hide resolved
parser/src/parser/tests/trace_columns.rs Outdated Show resolved Hide resolved
@tohrnii tohrnii force-pushed the tohrnii-parser-refactor branch from 3bc40c2 to f104ae7 Compare March 16, 2023 13:25
@tohrnii tohrnii requested a review from grjte March 16, 2023 13:26
@tohrnii
Copy link
Contributor Author

tohrnii commented Mar 16, 2023

Sorry, I merged the PRs in wrong order. The selector parser PR was merged into this branch instead.

grjte
grjte approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@grjte grjte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tohrnii tohrnii merged commit e67ad23 into next Mar 17, 2023
@tohrnii tohrnii deleted the tohrnii-parser-refactor branch March 17, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grjte grjte grjte approved these changes

@Fumuran Fumuran Awaiting requested review from Fumuran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tohrnii @grjte