refactor(ir): move constraints and graph to ConstraintBuilder #222
+66
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohrnii
force-pushed
the
tohrnii-constraint-builder-refactor
branch
from
c1bfbb9 to
14ac731
Compare
grjte
approved these changes
Mar 17, 2023
ir/src/constraints/graph.rs
Outdated
| pub(super) fn insert_op(&mut self, op: Operation) -> NodeIndex { | ||
| pub(crate) fn insert_op(&mut self, op: Operation) -> NodeIndex { |
There was a problem hiding this comment.
nit: I've been wondering about changing this to insert_node or insert_graph_node as well. Wdyt?
There was a problem hiding this comment.
Changed it to insert_node since it seems like graph is already implied here.
tohrnii
force-pushed
the
tohrnii-constraint-builder-refactor
branch
from
14ac731 to
0c3ab8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the graph and constraints to
ConstraintBuilder.