Write chiplet module constraints in AirScript #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grjte
suggested changes
Apr 25, 2023
tohrnii
reviewed
May 1, 2023
Fumuran
force-pushed
the
andrew-chiplets-module-constraints
branch
from
4a479d8 to
426330e
Compare
grjte
suggested changes
May 2, 2023
constraints/miden-vm/chiplets.air
Outdated
Comment on lines
16
to
18
| hash_chiplet([s[1], s[2], chip_columns]) when !s[0] | ||
| bitwise_chiplet([s[2], chip_columns]) when s[0] & !s[1] | ||
| memory_chiplet([chip_columns]) when s[0] & s[1] & !s[2]' |
There was a problem hiding this comment.
this should be chiplet_columns rather than chip_columns.
Also, I think this is simple enough now that we can just move this to the main chiplets evaluator and remove this helper evaluator
constraints/miden-vm/chiplets.air
Outdated
|
|
||
| ev chiplets_constraints(main: [s[3], chiplet_columns[15]]): | ||
| enf chiplet_selector_constraints([s]) | ||
|
|
There was a problem hiding this comment.
nit: I would remove this empty line
constraints/miden-vm/chiplets.air
Outdated
| ### Chiplets Constraints ########################################################################## | ||
|
|
||
| ev chiplets_constraints(main: [s[3], chiplet_columns[15]]): | ||
| enf chiplet_selector_constraints([s]) |
There was a problem hiding this comment.
nit: I would do a bit of renaming for more consistency with our other files
chiplet_selector_constraints->chiplet_selectorschiplet_constraints-> deletedchiplets_constraints->chiplets
grjte
suggested changes
May 3, 2023
constraints/miden-vm/chiplets.air
Outdated
|
|
||
| ### Chiplets Constraints ########################################################################## | ||
|
|
||
| ev chiplets(main: [s[3], chiplet_columns[15]]): |
There was a problem hiding this comment.
nit: it would be good to have a comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing: #201
This PR adds constraints for the chiplet module.