Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace Rand with SymbolAccess #256

Merged
merged 1 commit into from
Apr 18, 2023
Merged

refactor: replace Rand with SymbolAccess #256

merged 1 commit into from
Apr 18, 2023

Conversation

grjte
Copy link
Contributor

@grjte grjte commented Apr 17, 2023

This is a minimal refactor to remove Rand and replace it with SymbolAccess. We may want to do this a bit more cleanly in the parser, but that work will coincide with consolidating TraceBindingAccess into SymbolAccess, so I wanted to keep the changeset small for now.

@grjte grjte requested review from tohrnii and Fumuran April 17, 2023 14:43
tohrnii
tohrnii approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@tohrnii tohrnii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grjte, looks good to me.

bobbinth
bobbinth approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@grjte grjte force-pushed the grjte-refactor-0 branch from e06adfb to 692a111 Compare April 18, 2023 08:56
Base automatically changed from grjte-refactor-0 to next April 18, 2023 08:56
@grjte grjte force-pushed the grjte-refactor-1 branch from 4b6fe45 to 659e860 Compare April 18, 2023 08:58
@grjte grjte merged commit 457b915 into next Apr 18, 2023
@grjte grjte deleted the grjte-refactor-1 branch April 18, 2023 09:03
@grjte grjte mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

@tohrnii tohrnii tohrnii approved these changes

@Fumuran Fumuran Awaiting requested review from Fumuran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grjte @bobbinth @tohrnii