replace TraceBindingAccess with SymbolAccess
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Apr 18, 2023
Comment on lines
+26
to
33
| Self::Constant(_) => write!(f, "ConstantBinding"), | ||
| Self::Trace(_) => { | ||
| write!(f, "TraceBinding") | ||
| } | ||
| Self::PublicInput(_) => write!(f, "PublicInput"), | ||
| Self::PeriodicColumn(_, _) => write!(f, "PeriodicColumn"), | ||
| Self::Variable(_) => write!(f, "Variable"), | ||
| Self::Variable(_) => write!(f, "VariableBinding"), | ||
| Self::RandomValues(_, _) => write!(f, "RandomValues"), |
There was a problem hiding this comment.
Question: is there a reason why we sometimes add "Binding" at the end and sometimes don't?
There was a problem hiding this comment.
I think it's clearer in the errors if it has binding in it, but we don't ever refer to the other ones as bindings (even though they are). Not that this is a great reason - I prefer consistency too, but when I was looking at the errors I felt it was a little unclear without adding Binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates
TraceBindingAccessintoSymbolAccess. It aims to be as straightforward as possible without losing correctness, which means that some things are not fully addressed yet.TraceBindingAccesswithSymbolAccessin the parser/IR/codegenSymbolAccesshandling changes anywayRemaining items to address:
TraceAccessusage from parser. This will require some cleanup in the parser, so it will be done in a separate PRSliceaccess type. Previously this was only allowed for trace columns. I don't think there's a good reason not to allow this for variables/constants, but it needs to be done carefully. Similarly, within theListComprehensionwe need to be careful about this, but because theListComprehensionis still quite complicated I think this should be revisited separately.