Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conversion of SymbolAccess to TraceAccess for multi-column references #284

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Fix conversion of SymbolAccess to TraceAccess for multi-column references #284

merged 2 commits into from
Apr 28, 2023

Conversation

grjte
Copy link
Contributor

@grjte grjte commented Apr 28, 2023

This addresses #281. It adds a new test and fixes the issue with converting column group SymbolAccess references to TraceAccess

@grjte grjte requested a review from tohrnii April 28, 2023 15:00
tohrnii
tohrnii approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@tohrnii tohrnii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grjte, looks good.

Base automatically changed from grjte-fix-evaluators to next April 28, 2023 17:24
@tohrnii tohrnii merged commit 65bb98d into next Apr 28, 2023
@tohrnii tohrnii deleted the grjte-fix-evaluators-2 branch April 28, 2023 17:24
@tohrnii tohrnii mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tohrnii tohrnii tohrnii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grjte @tohrnii