masm: sorting boundary constraints #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-Kindi-0
reviewed
Jun 21, 2023
codegen/masm/src/codegen.rs
Outdated
| @@ -386,6 +385,8 @@ impl<'ast> AirVisitor<'ast> for CodeGenerator<'ast> { | |||
| self.writer | |||
| .header("Multiply by the composition coefficient"); | |||
|
|
|||
| // Note: The corretness of the load below relies on the integrity constraint being iterated | |||
There was a problem hiding this comment.
minor nit: correctness
There was a problem hiding this comment.
thanks, fixed :)
hackaugusto
force-pushed
the
hacka-masm-boundary-constraints-natural-order
branch
from
e88cbca to
a7c19bc
Compare
The Winterfell framework groups assertions by trace (main or auxiliary), by stride, and step (the first row to which the assertion is enforced). The assertions in a group are further ordered by the column which they apply to. In AirScript only single value assertions are supported, which means the stride is always `0` and grouping only happens by trace and step. And they are further ordered by column. The ordering described above is important because it defines the position of the composition coefficient to be used. This commits introduces the ordering by `step`. The ordering by column needs to be implemented later on.
hackaugusto
force-pushed
the
hacka-masm-boundary-constraints-natural-order
branch
from
a7c19bc to
7f94c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Winterfell framework groups assertions by trace (main or auxiliary), by stride, and step (the first row to which the assertion is enforced). The assertions in a group are further ordered by the column which they apply to.
In AirScript only single value assertions are supported, which means the stride is always
0and grouping only happens by trace and step. And they are further ordered by column.The ordering described above is important because it defines the position of the composition coefficient to be used.
This commits introduces the ordering by
step. The ordering by column needs to be implemented later on.