Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of Sub operation #80

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Addition of Sub operation #80

merged 1 commit into from
Nov 25, 2022

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Nov 22, 2022 •
edited
Loading

A Sub has been added to the Operation enum. Related issue: #68

@Fumuran Fumuran marked this pull request as ready for review November 23, 2022 21:50
@Fumuran Fumuran requested review from grjte and tohrnii November 23, 2022 21:51
@grjte grjte requested a review from Al-Kindi-0 November 25, 2022 10:40
Al-Kindi-0
Al-Kindi-0 reviewed Nov 25, 2022
View reviewed changes
Copy link
Collaborator

@Al-Kindi-0 Al-Kindi-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me.
Is there a need for tests or is this taken care of somewhere else?

grjte
grjte approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@grjte grjte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Overcastan!

@grjte
Copy link
Contributor

grjte commented Nov 25, 2022

Thank you! Looks good to me. Is there a need for tests or is this taken care of somewhere else?

@Al-Kindi-0 Normally yes, but we haven't set up a good testing system for the IR and codegen yet. It's being tracked in #7 and #9, and I'll be working on it next.

tohrnii
tohrnii approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@tohrnii tohrnii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Overcastan. Looks good.

@tohrnii tohrnii merged commit 6006070 into 0xPolygonMiden:next Nov 25, 2022
@Al-Kindi-0
Copy link
Collaborator

Thank you @grjte for the clarification.

This was referenced Nov 25, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Al-Kindi-0 Al-Kindi-0 Al-Kindi-0 left review comments

@grjte grjte grjte approved these changes

@tohrnii tohrnii tohrnii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fumuran @grjte @Al-Kindi-0 @tohrnii