-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc rendering issue #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes look good to me! However, the mdbook only deploys from main. We should probably do one of the following:
- keep docs in sync with next, and change the CI
book.yml
workflow to deploy when thenext
branch is updated - merge this to
main
instead and then rebasenext
I think this project is young enough and fast-moving enough that I'd probably go for the first option. What do you think?
4c6efb8
to
473bdc6
Compare
@grjte Agreed! I made the change to |
Thank you @tohrnii !
|
@Al-Kindi-0 To answer your questions:
|
Thank you! |
473bdc6
to
642fb60
Compare
@Al-Kindi-0 Thank you. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Addressing #78.