fix codegen for auxiliary constraint degrees #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohrnii
suggested changes
Dec 3, 2022
There was a problem hiding this comment.
Looks good! Thanks for fixing this. I think there's another bug just below in line:
// define the number of aux trace boundary constraints `num_aux_assertions`.
new.line("let num_aux_assertions = 0;");
This should probably be:
// define the number of aux trace boundary constraints `num_aux_assertions`.
new.line(format!(
"let num_aux_assertions = {};",
ir.num_aux_assertions()
));
Oh good point! Can't believe I missed that. Thanks! |
grjte
force-pushed
the
grjte-fix-aux-codegen
branch
from
0e8d661 to
57ae403
Compare
tohrnii
approved these changes
Dec 3, 2022
Al-Kindi-0
approved these changes
Dec 3, 2022
bobbinth
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the declaration of the constraint degrees for constraints in the auxiliary trace, which was previously declaring empty vector in all cases.