Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo link to mdbook #93

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Add repo link to mdbook #93

merged 1 commit into from
Dec 5, 2022

Conversation

tohrnii
Copy link
Contributor

@tohrnii tohrnii commented Dec 3, 2022

Question: Should the contributing guidelines be added to mdbook as well if the docs could be a possible entry point for people or maybe just added to the mdbook and removed from repo readme?

Comment on lines 19 to 20
The code for AirScript can be found [here](https://github.com/0xPolygonMiden/air-script/).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to put the link right at the top so it's easiest to find. Maybe we could either edit the first sentence to include a link or add the sentence right after it?

Polygon Miden's AirScript is designed to make it simple to describe AIR constraints and generate efficient and accurate code in the required target language.

OR

Polygon Miden's AirScript is designed to make it simple to describe AIR constraints and generate efficient and accurate code in the required target language. The code for AirScript can be found here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with the second option because it might be easy to overlook the link in the first.

Copy link

@jan-ferdinand jan-ferdinand Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another, potentially complementary, option is to go with the corresponding feature in mdbook. In book.toml:

[output.html]
git-repository-url = "https://github.com/0xPolygonMiden/air-script/"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-ferdinand Thanks. This looks great.

@grjte
Copy link
Contributor

grjte commented Dec 3, 2022

I think it's good as you've done it for now without contributing info in the docs, but I don't feel strongly.

@tohrnii tohrnii force-pushed the docs branch 2 times, most recently from 1c0b649 to 7287eff Compare December 3, 2022 21:38
@tohrnii
Copy link
Contributor Author

tohrnii commented Dec 3, 2022

I realized that the README changes should probably be made to main so I've removed it from this PR and will open another one that merges to main.

@tohrnii tohrnii changed the title Add repo link to mdbook and contributing guidelines to readme Add repo link to mdbook Dec 3, 2022
Copy link
Collaborator

@Al-Kindi-0 Al-Kindi-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

Copy link
Contributor

@Fumuran Fumuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, thank you!

@tohrnii tohrnii merged commit 3a7824e into next Dec 5, 2022
@tohrnii tohrnii deleted the docs branch December 5, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants