Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for constants to codegen #95

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Add support for constants to codegen #95

merged 4 commits into from
Dec 8, 2022

Conversation

tohrnii
Copy link
Contributor

@tohrnii tohrnii commented Dec 5, 2022

Partly addressing #60.

@tohrnii tohrnii changed the base branch from main to next December 5, 2022 07:57
@tohrnii tohrnii force-pushed the tohrnii-constants-codegen branch 3 times, most recently from 1642b9c to a10b383 Compare December 5, 2022 09:25
@tohrnii tohrnii marked this pull request as ready for review December 5, 2022 09:29
@tohrnii tohrnii force-pushed the tohrnii-constants-codegen branch from a10b383 to 57a77da Compare December 5, 2022 09:39
@tohrnii tohrnii changed the base branch from next to grjte-ir-trace-ref December 5, 2022 17:54
@tohrnii tohrnii changed the base branch from grjte-ir-trace-ref to next December 5, 2022 17:54
@tohrnii tohrnii force-pushed the tohrnii-constants-codegen branch from 57a77da to 2659afa Compare December 5, 2022 21:44
@bobbinth bobbinth changed the base branch from next to tohrnii-constants-ir December 5, 2022 22:26
@bobbinth bobbinth changed the base branch from tohrnii-constants-ir to next December 5, 2022 22:27
@tohrnii tohrnii mentioned this pull request Dec 6, 2022
Merged
14 tasks
@tohrnii tohrnii changed the base branch from next to tohrnii-constants-ir December 6, 2022 03:04
@tohrnii tohrnii changed the base branch from tohrnii-constants-ir to next December 6, 2022 03:05
@tohrnii tohrnii force-pushed the tohrnii-constants-codegen branch from 2659afa to b1eab2e Compare December 6, 2022 15:15
@tohrnii tohrnii changed the base branch from next to tohrnii-constants-ir December 6, 2022 15:16
@tohrnii tohrnii force-pushed the tohrnii-constants-codegen branch 2 times, most recently from aaf85a3 to 060c5b8 Compare December 6, 2022 15:33
bobbinth
bobbinth requested changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few small comments inline.

air-script/tests/constants/constants.rs Outdated Show resolved Hide resolved
air-script/tests/constants/constants.rs Outdated Show resolved Hide resolved
codegen/winterfell/src/air/transition_constraints.rs Show resolved Hide resolved
codegen/winterfell/src/air/boundary_constraints.rs Show resolved Hide resolved
@tohrnii tohrnii mentioned this pull request Dec 7, 2022
Closed
@tohrnii tohrnii force-pushed the tohrnii-constants-codegen branch 3 times, most recently from 8f1c1dd to 0f23016 Compare December 7, 2022 12:11
@tohrnii tohrnii force-pushed the tohrnii-constants-codegen branch 2 times, most recently from 87f2122 to 40e4f0e Compare December 7, 2022 16:19
@tohrnii tohrnii requested a review from bobbinth December 7, 2022 16:22
@tohrnii tohrnii force-pushed the tohrnii-constants-codegen branch from 40e4f0e to 1cd8e70 Compare December 7, 2022 16:27
bobbinth
bobbinth approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

Base automatically changed from tohrnii-constants-ir to next December 8, 2022 03:11
Fumuran
Fumuran approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@Fumuran Fumuran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@tohrnii tohrnii merged commit b7b2f10 into next Dec 8, 2022
@tohrnii tohrnii deleted the tohrnii-constants-codegen branch December 8, 2022 03:31
@tohrnii tohrnii mentioned this pull request Dec 8, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fumuran Fumuran Fumuran approved these changes

@bobbinth bobbinth bobbinth approved these changes

@Al-Kindi-0 Al-Kindi-0 Al-Kindi-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tohrnii @Fumuran @bobbinth @Al-Kindi-0