fix: restore re-exports but using alloc #291
Conversation
mFragaBA
force-pushed
the
mFragaBA/temporary-re-exports-for-deprecated-modules
branch
from
7c64a17 to
0a99d47
Compare
|
mFragaBA
changed the title
| @@ -1,6 +1,7 @@ | |||
| //! Utilities used in this crate which can also be generally useful downstream. | |||
|
|
|||
| use alloc::string::String; | |||
| pub use alloc::{format, vec}; | |||
There was a problem hiding this comment.
These macros were originally exported from the string and collections modules re-exported from winter-utils, so re-exporting them here isn't quite correct. See #292 for the patch that restores the original setup. I think @bobbinth is planning to merge both of those here shortly and cut new releases to fix downstream crates.
There was a problem hiding this comment.
oh great news then! I thought it they were intentionally removed from winterfell so this was more of a workaround. I'll close this PR then. Thanks for the explanation @bitwalker!
There was a problem hiding this comment.
btw, considering the deprecated modules will get removed eventually. Should we make a PR on miden-vm changing the usages of these re-exports for alloc::***, or do we just change the re-exports in miden-crypto?
There was a problem hiding this comment.
This is already done in 0xPolygonMiden/miden-vm#1277 - we just need to merge it an release it :)
|
As mentioned above, these changes are not needed after #292 got merged |
Describe your changes
On #290, with part of those changes we removed the re-exports of
Vec,BTreeMap,BTreeSet, among others which breaks compilation of crates likemiden-vm. Here we restore the re-exports (but usingalloc), and in a future PR we should remove those as well (maybe for 0.9?)Also, I tried marking those re-exports as deprecated but I couldn't make them appear (might be related to this issue)
Also: should I change the crate's version for the release in this PR or in a separate one?
Checklist before requesting a review
nextaccording to naming convention.