Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to list notes, accounts, and nullifiers #163

Closed
hackaugusto opened this issue Jan 18, 2024 · 4 comments
Closed

Add pagination to list notes, accounts, and nullifiers #163

hackaugusto opened this issue Jan 18, 2024 · 4 comments
Assignees
Milestone

Comments

@hackaugusto
Copy link
Contributor

The current version of the endpoints to list notes, accounts, and nullifiers does not have pagination. The best practice is to return a continuation token.

@bobbinth
Copy link
Contributor

An alternative is to remove these endpoints altogether. They were meant solely for testing, but I'm not sure we are using them.

cc @Mirko-von-Leipzig.

@Mirko-von-Leipzig
Copy link
Contributor

If they're not in use then I'm inclined to delete them :). Adding pagination via a continuation token would also be rather simple to implement though.

I assume the wallet/client use the rpc server list, and don't directly access the "internal" store api @igamigo?

@igamigo
Copy link
Collaborator

igamigo commented Oct 28, 2024

I assume the wallet/client use the rpc server list, and don't directly access the "internal" store api @igamigo?

Correct. These endpoints have been useful in the past for debugging but I don't think they've been used as of recently so I agree it would be good to delete them.

@Mirko-von-Leipzig
Copy link
Contributor

Closed by #608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants