Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): remove testing endpoints #608

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

Mirko-von-Leipzig
Copy link
Contributor

Removes store RPC test-only endpoints.

Closes #163.

@Mirko-von-Leipzig Mirko-von-Leipzig force-pushed the mirko/feat/remove-test-endpoints branch from 16e44af to 1ad24d6 Compare January 10, 2025 13:42
@Mirko-von-Leipzig Mirko-von-Leipzig marked this pull request as ready for review January 10, 2025 13:43
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you. I left one question/comment inline.

Also, we should remove mentions of this endpoints from README files (e.g., here).

crates/store/src/server/api.rs Show resolved Hide resolved
@Mirko-von-Leipzig Mirko-von-Leipzig force-pushed the mirko/feat/remove-test-endpoints branch from eb470ba to 52d620d Compare January 13, 2025 09:59
@Mirko-von-Leipzig Mirko-von-Leipzig merged commit ef07bbc into next Jan 13, 2025
8 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the mirko/feat/remove-test-endpoints branch January 13, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants