Add reproducible builds #267
Conversation
|
@hackaugusto for now we are not using the matrix capabilities in the CI. Should we still keep the matrix structure for future proofing or should we switch to a simpler CI structure? |
I don't mind either way. |
Removed the matrix to simplify CI for now |
| # Remove Cargo.lock from gitignore if creating an executable, leave it for libraries | ||
| # More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html | ||
| Cargo.lock | ||
| # Cargo.lock |
There was a problem hiding this comment.
Is this comment still relevant?
| @@ -0,0 +1 @@ | |||
| 1.75 | |||
There was a problem hiding this comment.
We should probably set MSRV in the workspace Cargo.toml file and I'm curious if there is a way to ensure that one and this one are in sync.
There was a problem hiding this comment.
Will add it to the cargo.toml, i can check but I do not think that there is a standard way to check that both versions match.
There was a problem hiding this comment.
After doing a quick research i have not found a standard way of checking that all crates match the version of the rust-toolchain file. Hence decided to create a PR to address that and fix your comments:
#272
This improves the reliability of the builds for the miden-node enabling more consistency and reproducibility.
closes: #251