feat: return tx block height info (decoupled approach) #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bobbinth
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Looks good! Thank you! I left a couple of small comments inline.
As mentioned in the issue, I think this is a better approach as additional code complexity is pretty low and the downsides of doing this vs. putting transactions into the AccountSummary are pretty small.
|
Oh - and let's update the readme docs and the changelog. |
igamigo
approved these changes
Jun 14, 2024
mFragaBA
force-pushed
the
mFragaBA-return-tx-and-nullifier-block-height-info
branch
2 times, most recently
from
0d98a50 to
f232d23
Compare
bobbinth
approved these changes
Jun 14, 2024
mFragaBA
force-pushed
the
mFragaBA-return-tx-and-nullifier-block-height-info
branch
from
378167c to
aa1a40b
Compare
…ifierUpdate contain
|
I'll close the other PR (#383) |
bobbinth
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #380
This is an alternative approach to #383