Removed note details from sync responses #462
Conversation
| let tip = select_block_header_by_block_num(conn, None)? | ||
| .ok_or(NoteSyncError::EmptyBlockHeadersTable)?; |
There was a problem hiding this comment.
Since we know the latest block number in the state - we may be able to pass chain_tip_num into this function and potentially avoid this database query (i.e., we can always do just 1 query here instead of sometimes doing 2 queries and sometimes 1).
There was a problem hiding this comment.
We don't store latest block number in the State in-memory by now or I can't find a place you mean. Should I update our in-memory state in order to save the current block number?
There was a problem hiding this comment.
We do have latest_block_num() function on the State. Let's create an issue for this optimization (could be a "good first issue").
There was a problem hiding this comment.
@bobbinth ah, thank you, I forgot about this feature of chain mmr. :)
Resolves #309
Introduced
NoteSyncRecorddomain type which omits note details unnecessary for state synchronizations. Refactored code, removed excessive function (select_notes_since_block_by_tag_and_sendercan work asselect_notes_since_block_by_tagif we provide empty sender list).