-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: reorganize packaging and release workflows #473
Closed
Closed
+317
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invokes calls to non-existent packages; still to be added.
The packaging is still bare for now, but deploy waits on the release artifacts to be uploaded before downloading and deploying them.
Plus some minor fixes and typos. Probably still some issues with naming and suffixes but that's okay.
Mirko-von-Leipzig
force-pushed
the
mirko-devops-testing
branch
from
August 29, 2024 11:44
89e776f
to
52aa0bc
Compare
Mirko-von-Leipzig
force-pushed
the
mirko-devops-testing
branch
from
August 29, 2024 11:52
f0e71e2
to
36901a1
Compare
Mirko-von-Leipzig
force-pushed
the
mirko-devops-testing
branch
from
August 29, 2024 11:57
ce616bc
to
04c4b11
Compare
Mirko-von-Leipzig
force-pushed
the
mirko-devops-testing
branch
2 times, most recently
from
August 29, 2024 12:28
bebd913
to
2c1cbe7
Compare
Mirko-von-Leipzig
force-pushed
the
mirko-devops-testing
branch
from
August 29, 2024 12:45
2711daa
to
45bb5d7
Compare
Mirko-von-Leipzig
force-pushed
the
mirko-devops-testing
branch
4 times, most recently
from
August 29, 2024 12:56
62e4202
to
6471b07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP meant to demonstrate a set of workflows which allows us to combine, re-use and separate testnet and devnet deployments.
The essence of this refactor is creating two actions:
1. Package
This generates the
miden-node
andmiden-faucet
packages -- but notable only generates the files. No uploading or tagging etc. All meta-data like that should come in as an input.2. Deploy
This action takes in the aws ssm credentials and filepaths to the packages. It then uses
scp
to copy the packages across, and thenssm
to do the deployment process similar to what is happening now.The workflows are now split into
release
anddeploy_devnet
using the above actions:The nice thing is that the actions don't care about architecture or tags etc. That's up to the workflow to setup. And similarly we get to re-use the actions.
I'd also like an action to wrap the ssm command + polling loop nonsense but that's not super relevant here.