Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reorganize packaging and release workflows #473

Closed
wants to merge 31 commits into from

Conversation

Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig commented Aug 28, 2024

This is a WIP meant to demonstrate a set of workflows which allows us to combine, re-use and separate testnet and devnet deployments.

⚠️ expect naming inconsistencies, typos and other gnarly minutia.


The essence of this refactor is creating two actions:

1. Package

This generates the miden-node and miden-faucet packages -- but notable only generates the files. No uploading or tagging etc. All meta-data like that should come in as an input.

2. Deploy

This action takes in the aws ssm credentials and filepaths to the packages. It then uses scp to copy the packages across, and then ssm to do the deployment process similar to what is happening now.


The workflows are now split into release and deploy_devnet using the above actions:

  1. devnet generates the arm package and then deploys it.
  2. release has 3 jobs
    1. generate and upload amd package
    2. generate and upload arm package
    3. wait for arm package to be available and deploy it to testnet

The nice thing is that the actions don't care about architecture or tags etc. That's up to the workflow to setup. And similarly we get to re-use the actions.


⚠️ I haven't actually tested the scp via ssm but I believe it is possible according to the docs. And the actions are currently just stubs..

I'd also like an action to wrap the ssm command + polling loop nonsense but that's not super relevant here.

Invokes calls to non-existent packages; still to be added.
The packaging is still bare for now, but deploy waits on the release
artifacts to be uploaded before downloading and deploying them.
Plus some minor fixes and typos.

Probably still some issues with naming and suffixes but that's okay.
@Mirko-von-Leipzig Mirko-von-Leipzig force-pushed the mirko-devops-testing branch 2 times, most recently from bebd913 to 2c1cbe7 Compare August 29, 2024 12:28
@Mirko-von-Leipzig Mirko-von-Leipzig force-pushed the mirko-devops-testing branch 4 times, most recently from 62e4202 to 6471b07 Compare August 29, 2024 12:56
@Mirko-von-Leipzig
Copy link
Contributor Author

Implemented in #546 and #547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant